Fix repeat of negative prompt#4335
Merged
patrickvonplaten merged 2 commits intohuggingface:mainfrom Jul 28, 2023
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Hey @kathath, Can you explain how this PR fixes the negative prompt? To me both implementations you are showing are identical |
Contributor
Author
|
@patrickvonplaten What changed is that when negative_prompt is not None, there is no repeat by batch_size anymore. When negative prompts are given, the code expects the negative prompt list to be the same length as the prompt list. This is checked in line |
Contributor
|
Thanks for the explanation! |
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
fix repeat of negative prompt
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
fix repeat of negative prompt
orpatashnik
pushed a commit
to orpatashnik/diffusers
that referenced
this pull request
Aug 1, 2023
fix repeat of negative prompt
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
fix repeat of negative prompt
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
fix repeat of negative prompt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4149 (running a batch of prompts and negative prompts with the SemanticStableDiffusionPipeline causes an error).
The same bug was fixed for the StableDiffusion pipeline in #1120 .
Who can review?
@patrickvonplaten